apparmor: prohibit /sys/firmware/** from being accessed#26618
Merged
Conversation
Some firmware information including SMBIOS and ACPI tables were unexpectedly exposed Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Member
Author
Contributor
|
I can't see any valid use cases for accessing this directory so LGTM. |
Contributor
|
IANAM, but lgtm. |
Contributor
|
LGTM |
This was referenced Sep 18, 2016
AkihiroSuda
added a commit
to AkihiroSuda/docker
that referenced
this pull request
Sep 20, 2016
TestBuildApiDockerFileRemote has been consistently failing (EPERM) on the host with moby#26618, which prohibits /sys/firmware from being accessed using apparmor. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
This was referenced Sep 23, 2016
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
TestBuildApiDockerFileRemote has been consistently failing (EPERM) on the host with moby#26618, which prohibits /sys/firmware from being accessed using apparmor. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp> Signed-off-by: majiuyue 00385406 <majiuyue@huawei.com>
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
Fix flaky test: TestBuildApiDockerFileRemote TestBuildApiDockerFileRemote has been consistently failing (EPERM) on the host with moby#26618, which prohibits /sys/firmware from being accessed using apparmor. Cherry-pick from moby#26720 fix issue moby#183 Issues info: Issue ID: 183 Title: flaky test: TestBuildApiDockerFileRemote Issue url: moby#183 See merge request docker/docker!294
tbaumann
added a commit
to tbaumann/homeassistant-addons
that referenced
this pull request
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some firmware information including SMBIOS and ACPI tables were unexpectedly exposed.
Basically they shouldn't contain sensitive information, but some exceptions:
/sys/firmware/acpi/tables/{SLIC,MSDM}: Windows license information: http://feishare.com/attachments/article/265/microsoft-software-licensing-tables.pdf (original copy at microsoft.com seems 404)/sys/firmware/ibft/target0/chap-secret: iSCSI CHAP secret: ftp://ftp.software.ibm.com/systems/support/bladecenter/iscsi_boot_firmware_table_v1.03.pdfI think this issue should be fixed but not critical.
- What I did
Prohibit /sys/firmware/** from being accessed.
- How I did it
Modified the template for the default apparmor profile
- How to verify it
- Description for the changelog
apparmor: prohibit /sys/firmware/** from being accessed
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp