docs: fix Nushell-Homebrew setup instructions#1495
Merged
Conversation
Member
|
Can anyone who uses nushell test this and confirm it fixes the problem? @kimufly can you write a unit test for this issue? |
Contributor
|
We don't really test these setup instructions in any of our CI pipelines. The Nushell tests just directly setup using Nu script instead of each permutation of Shell+asdf installation method. If we were to add tests I guess they would live https://github.com/asdf-vm/asdf/blob/master/test/asdf_nu.bats but would have to detect OS and execute conditionally. |
Contributor
|
I'm going to merge this and we can improve the Nushell test suite over time. There are a few issues already raised in other Issues which are being addressed individually. |
jthegedus
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the problem that ASDF_NU_DIR does not fight for an invisible newline character at the end of the brew --prefix command