close
Skip to content

docs: fix Nushell-Homebrew setup instructions#1495

Merged
jthegedus merged 1 commit into
asdf-vm:masterfrom
kimufly:patch-1
Mar 21, 2023
Merged

docs: fix Nushell-Homebrew setup instructions#1495
jthegedus merged 1 commit into
asdf-vm:masterfrom
kimufly:patch-1

Conversation

@kimufly

@kimufly kimufly commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Summary

Fix the problem that ASDF_NU_DIR does not fight for an invisible newline character at the end of the brew --prefix command

@kimufly kimufly requested a review from a team as a code owner March 6, 2023 11:22
@kimufly kimufly changed the title Fix the problem that ASDF_NU_DIR does not fight for an invisible newline character at the end of the brew --prefix command fix: 'Nushell & Homebrew' doc wrong Mar 6, 2023
@Stratus3D

Copy link
Copy Markdown
Member

Can anyone who uses nushell test this and confirm it fixes the problem?

@kimufly can you write a unit test for this issue?

@jthegedus

Copy link
Copy Markdown
Contributor

We don't really test these setup instructions in any of our CI pipelines. The Nushell tests just directly setup using Nu script instead of each permutation of Shell+asdf installation method.

If we were to add tests I guess they would live https://github.com/asdf-vm/asdf/blob/master/test/asdf_nu.bats but would have to detect OS and execute conditionally.

@jthegedus jthegedus changed the title fix: 'Nushell & Homebrew' doc wrong docs: fix Nushell-Homebrew setup instructions Mar 8, 2023
@jthegedus

Copy link
Copy Markdown
Contributor

I'm going to merge this and we can improve the Nushell test suite over time. There are a few issues already raised in other Issues which are being addressed individually.

@jthegedus jthegedus merged commit 49e541a into asdf-vm:master Mar 21, 2023
botp pushed a commit to botp/asdf that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants