close
Skip to content

fix: Avoid mention of ASDF_NU_DIR#1660

Merged
jthegedus merged 2 commits into
asdf-vm:masterfrom
hyperupcall:hyperupcall-no-asdf-nu-dir
Jan 9, 2024
Merged

fix: Avoid mention of ASDF_NU_DIR#1660
jthegedus merged 2 commits into
asdf-vm:masterfrom
hyperupcall:hyperupcall-no-asdf-nu-dir

Conversation

@hyperupcall

@hyperupcall hyperupcall commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Summary

It was a mistake to read the ASDF_NU_DIR environment variable (it looks like use of it snuck through the CR). Since it serves the exact same purpose as ASDF_DIR, it is redundant. Remove mention of this variable, but keep reading it for backwards-compatability.

Closes #1623
Closes #1630

Other Information

@hyperupcall hyperupcall requested a review from a team as a code owner October 6, 2023 10:53
@hyperupcall

hyperupcall commented Jan 3, 2024

Copy link
Copy Markdown
Contributor Author

CI fails due to errors with fish installation. That is fixed by #1705

@jthegedus jthegedus merged commit dfea89c into asdf-vm:master Jan 9, 2024
Stratus3D pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isn't work in termux bug: Error: nu::shell::access_beyond_end

2 participants