fix: completions for zsh and fish

[manuraj17]

Summary

Updates completions for fish and shell to use the new commands format without hyphens.

Fixes: #1908

[manuraj17]

Ran into some failures in

./scripts/test.bash

I need to check those, new to the project.

[Stratus3D]

Thanks for the PR @manuraj17 ! I'm going to merge this as it is an improvement. But suggestions for things like asdf plug* don't suggest just asdf plugin but rather all plugin subcommands, which I think is not in line with what most people expect. I'm going to tweak it myself tomorrow and then try to publish a new patch version of asdf.

[kemko]

@Stratus3D @manuraj17

complete: too many arguments

/opt/homebrew/share/fish/vendor_completions.d/asdf.fish (line 58):
complete -f -c asdf -n __fish_asdf_needs_command -a plugin add -d "Add git repo as plugin"
^
from sourcing file /opt/homebrew/share/fish/vendor_completions.d/asdf.fish
	called on line 29 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
	called during startup

(Type 'help complete' for related documentation)
complete: too many arguments

/opt/homebrew/share/fish/vendor_completions.d/asdf.fish (line 64):
complete -f -c asdf -n __fish_asdf_needs_command -a plugin list -d "List installed plugins"
^
from sourcing file /opt/homebrew/share/fish/vendor_completions.d/asdf.fish
	called on line 29 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
	called during startup

(Type 'help complete' for related documentation)
complete: too many arguments

/opt/homebrew/share/fish/vendor_completions.d/asdf.fish (line 67):
complete -f -c asdf -n __fish_asdf_needs_command -a plugin list all -d "List all existing plugins"
^
from sourcing file /opt/homebrew/share/fish/vendor_completions.d/asdf.fish
	called on line 29 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
	called during startup

(Type 'help complete' for related documentation)
complete: too many arguments

/opt/homebrew/share/fish/vendor_completions.d/asdf.fish (line 70):
complete -f -c asdf -n __fish_asdf_needs_command -a plugin remove -d "Remove plugin and package versions"
^
from sourcing file /opt/homebrew/share/fish/vendor_completions.d/asdf.fish
	called on line 29 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
	called during startup

(Type 'help complete' for related documentation)
complete: too many arguments

/opt/homebrew/share/fish/vendor_completions.d/asdf.fish (line 74):
complete -f -c asdf -n __fish_asdf_needs_command -a plugin update -d "Update plugin"
^
from sourcing file /opt/homebrew/share/fish/vendor_completions.d/asdf.fish
	called on line 29 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
	called during startup

(Type 'help complete' for related documentation)
complete: too many arguments

/opt/homebrew/share/fish/vendor_completions.d/asdf.fish (line 111):
complete -f -c asdf -n __fish_asdf_needs_command -a list all -d "List all versions of a package"
^
from sourcing file /opt/homebrew/share/fish/vendor_completions.d/asdf.fish
	called on line 29 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
	called during startup

(Type 'help complete' for related documentation)

seems like not tested.

[keldin-coding]

complete -f -c asdf -n __fish_asdf_needs_command -a 'plugin list all' -d "List all existing plugins"

I was able to "fix" this by wrapping the words passed to the -a argument here in quotes. However, the autocomplete still does not work as I would expect. For example asdf plugin completes, but none of the subcommands of that afterwards.

I would imagine some working with __fish_seen_subcommand_from will have to be used since all the commands have been converted to nested subcommands

[manuraj17]

I was travelling when this got merged and I see the issue. It was not tested completely, I was still exploring fish completions and there are some more work. Apologies for the trouble caused.

[manuraj17]

Folks, I have made some changes here #1936. I tested it by copying the completions into my fish shell config directory and running it. Let me know if there are still any edge cases. @keldin-coding @kemko

cc @Stratus3D

[Stratus3D]

Thanks @manuraj17 ! Will test that PR more thoroughly and merge if it looks good 👍