fix: repair invalid fish shell completion code#1936
Merged
Conversation
f4a5e6e to
b757f1b
Compare
Member
|
I don't see a suggestion for Plugin should be presented here as it is an option. |
- Removed update command - Removed global & local command
dbd7641 to
88397cc
Compare
Contributor
Author
|
@Stratus3D Added I feel there could be more refinements for ex: currently |
Stratus3D
approved these changes
Feb 11, 2025
Member
|
Thanks @manuraj17 ! |
This was referenced Feb 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes related to #1934 & #1908
Earlier changes introduced in #1912 broke the fish shell completions. The changes were for both
zshandfish. Though, here we are making changes only for fixingfish.There is room for improvement but the fix right now is focused to make the broken stuff work.
Below commands are removed
globallocalupdate