close
Skip to content

fix: repair invalid fish shell completion code#1936

Merged
Stratus3D merged 2 commits into
asdf-vm:masterfrom
manuraj17:fix-fish-completions
Feb 11, 2025
Merged

fix: repair invalid fish shell completion code#1936
Stratus3D merged 2 commits into
asdf-vm:masterfrom
manuraj17:fix-fish-completions

Conversation

@manuraj17

Copy link
Copy Markdown
Contributor

Fixes related to #1934 & #1908

Earlier changes introduced in #1912 broke the fish shell completions. The changes were for both zsh and fish. Though, here we are making changes only for fixing fish.

There is room for improvement but the fix right now is focused to make the broken stuff work.

Below commands are removed

  • global
  • local
  • update

@manuraj17 manuraj17 requested a review from a team as a code owner February 10, 2025 11:22
@manuraj17 manuraj17 force-pushed the fix-fish-completions branch from f4a5e6e to b757f1b Compare February 10, 2025 11:23
@Stratus3D

Copy link
Copy Markdown
Member

I don't see a suggestion for asdf plugin:

~> asdf 
current  (Display version set or being used for package)  set                                       (Set version for a plugin)
info        (Print OS, Shell and ASDF debug information)  shimversions  (List the plugins and versions that provide a command)
install        (Install a specific version of a package)  uninstall                   (Remove a specific version of a package)
latest         (Show latest stable version of a package)  where                (Display install path for an installed version)
list              (List installed versions of a package)  which                        (Display executable path for a command)
reshim         (Recreate shims for version of a package) 

Plugin should be presented here as it is an option.

@manuraj17 manuraj17 force-pushed the fix-fish-completions branch from dbd7641 to 88397cc Compare February 11, 2025 02:35
@manuraj17

Copy link
Copy Markdown
Contributor Author

@Stratus3D Added plugin option

I feel there could be more refinements for ex: currently asdf plugin list <tab> gives an all out list and then all. I can check on them, but since the current release has this broken maybe I can work on those incrementally since this works at the moment.

@Stratus3D Stratus3D changed the title fix: fish shell completions fix: correct fish shell completion errors Feb 11, 2025
@Stratus3D Stratus3D changed the title fix: correct fish shell completion errors fix: fish shell completion errors Feb 11, 2025
@Stratus3D Stratus3D changed the title fix: fish shell completion errors fix: get rid of fish shell completion errors Feb 11, 2025
@Stratus3D Stratus3D changed the title fix: get rid of fish shell completion errors fix: repair invalid fish shell completion code Feb 11, 2025
@Stratus3D Stratus3D merged commit 8388f99 into asdf-vm:master Feb 11, 2025
@Stratus3D

Copy link
Copy Markdown
Member

Thanks @manuraj17 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants