fix: regex validate plugin names on plugin add cmd#1010
Merged
jthegedus merged 9 commits intoJul 29, 2021
Conversation
jthegedus
commented
Jul 25, 2021
Member
|
Is |
Contributor
Author
|
I am not sure of the portability of I think we just wait until someone flags |
Member
|
@jthegedus sounds good. I didn't realize core was already using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply regex validation to plugin names when
asdf plugin addis used.Regex is
^[a-zA-Z0-9_-]+$and applied viagrep --extended-regexp.Fixes: #789
Other Information
^[a-zA-Z0-9-]$was the original discussion. I have added_as well as the regex will then cover all popular naming conventions (camelCase, snake_case, kebab-case, PascalCase and UPPER_SNAKE).We may restrict this regex further in future because of platform independent handling of filesystem paths with varying cases as discussed in asdf-vm/asdf-plugins#28