close
Skip to content

fix: do not print find errors#1102

Merged
jthegedus merged 1 commit into
asdf-vm:masterfrom
nozaq:fix-find-errs
Dec 5, 2021
Merged

fix: do not print find errors#1102
jthegedus merged 1 commit into
asdf-vm:masterfrom
nozaq:fix-find-errs

Conversation

@nozaq

@nozaq nozaq commented Dec 4, 2021

Copy link
Copy Markdown
Contributor

Summary

Do not print errors find command produces when no lib/commands exists under plugin directories.

Fixes: #1101

Other Information

Example output from asdf help on the current master branch.

...

RESOURCES
GitHub: https://github.com/asdf-vm/asdf
Docs:   https://asdf-vm.com
find: ‘/home/_/.asdf/plugins/deno/lib/commands’: No such file or directory

PLUGIN direnv
  asdf direnv
  asdf direnv hook asdf
find: ‘/home/_/.asdf/plugins/nodejs/lib/commands’: No such file or directory
find: ‘/home/_/.asdf/plugins/python/lib/commands’: No such file or directory
find: ‘/home/_/.asdf/plugins/ruby/lib/commands’: No such file or directory
find: ‘/home/_/.asdf/plugins/terraform/lib/commands’: No such file or directory

"Late but latest"
-- Rajinikanth

After applying this fix.

...

RESOURCES
GitHub: https://github.com/asdf-vm/asdf
Docs:   https://asdf-vm.com

PLUGIN direnv
  asdf direnv
  asdf direnv hook asdf

"Late but latest"
-- Rajinikanth

@nozaq nozaq requested a review from a team as a code owner December 4, 2021 10:09
@nozaq

nozaq commented Dec 5, 2021

Copy link
Copy Markdown
Contributor Author

Just pushed a fix for shfmt check.

@jthegedus jthegedus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching.

@jthegedus jthegedus merged commit 5992abb into asdf-vm:master Dec 5, 2021
@nozaq nozaq deleted the fix-find-errs branch December 5, 2021 08:24
@jthegedus jthegedus added this to the v0.10.0 milestone Dec 5, 2021
@pre pre mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: asdf help produces errors for plugins without extension commands

2 participants