close
Skip to content

fix: lint scripts for local and CI#961

Merged
jthegedus merged 3 commits into
asdf-vm:masterfrom
jthegedus:fix/lint-script
May 26, 2021
Merged

fix: lint scripts for local and CI#961
jthegedus merged 3 commits into
asdf-vm:masterfrom
jthegedus:fix/lint-script

Conversation

@jthegedus

Copy link
Copy Markdown
Contributor

Summary

Revert changes to local workflows from #956

  • script for Shellcheck to run locally and in CI
  • script for Shfmt to run locally and in CI
  • update release docs to reflect new pre-release workflow

@Stratus3D

Copy link
Copy Markdown
Member

Thanks for the PR @jthegedus !

@Stratus3D

Copy link
Copy Markdown
Member

I work with a lot of different projects so having a scripts directory with scripts helps remind me what I need to do before creating a PR on GitHub.

@jthegedus

jthegedus commented May 26, 2021

Copy link
Copy Markdown
Contributor Author

Fair enough. I tend to rely on the CI more myself, or githooks if available. Still, would likely need these scripts for githooks!

@jthegedus jthegedus merged commit 5dafbc8 into asdf-vm:master May 26, 2021
@jthegedus jthegedus deleted the fix/lint-script branch May 26, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants