build: bootstrap Gradle plugin repositories#15597
Conversation
✅ All tests passed ✅🏷️ Commit: 0196bd2 Learn more about TestLens at testlens.app. |
| * under the License. | ||
| */ | ||
|
|
||
| ext.configurePluginRepositories = { RepositoryHandler repositories -> |
There was a problem hiding this comment.
We have a settings repo plugin. I'm assuming we can't take a similar solution for the plugin repos? If not, can we at least move this configuration adjacent to that plugin (build-logic) so they're in the same location?
|
Yes, we can move the plugin-repositories.gradle file into the build-logic directory to keep the configuration adjacent to the build-logic plugin. This would require updating the 'apply from' paths in both settings.gradle files to reference the new location. |
|
I think we should merge to help @jamesfredley get the micronaut change merged quicker. Then we can revisit on the repo settings change. |
jamesfredley
left a comment
There was a problem hiding this comment.
We can revisit that one item later, if needed.
…nt repos Adopt the shared gradle/plugin-repositories.gradle bootstrap script introduced in #15597 (matrei) and remove the inline repositories blocks previously added to settings.gradle, buildSrc/settings.gradle, grails-forge/settings.gradle, grails-forge/buildSrc/settings.gradle, grails-gradle/settings.gradle, and grails-gradle/buildSrc/settings.gradle. All seven settings files now resolve plugin repositories through the same configurePluginRepositories closure, eliminating the copy-paste drift flagged in PR #15365 review (jdaugherty) and gaining the additional repos PR #15365's inline blocks did not cover (mavenLocal env hook, sonatype snapshots for cloud.wondrify.*, ASF staging for grails-publish releases and org.apache.groovy:groovy.*). PR #15597 targets 7.0.x; this merge brings the same fix to 8.0.x while preserving the original commit (Mattias Reichel) so the bootstrap fix is attributed correctly across both branches. Closes gh-15596 Assisted-by: claude-code:claude-opus-4-7
|
@matrei would you be ok to relocate the config with the build-logic? James & I wanted to get this merged so we can get the micronaut changes merged |
Closes gh-15596