Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs#15688
Step 1 (PR-I, DRAFT): Rename grails.gorm.tests test packages to grails.gorm.specs#15688jamesfredley wants to merge 3 commits into
Conversation
Renames the legacy grails.gorm.tests Spock-spec packages to grails.gorm.specs in grails-data-hibernate5 and grails-datamapping-core-test, disambiguating the module-local specs from the shared grails.gorm.tests domain fixtures. DRAFT: extracted from the Hibernate 7 staging branch (PR #15654) per review feedback requesting the tests -> specs rename be split out. The mongo portion of this rename is carved separately in PR-E (#15685); the hibernate7 portion lives with the Hibernate 7 work. Parked as a draft pending project agreement on whether to adopt the rename. Assisted-by: claude-code:claude-4.7-opus
…R-F #15689) Continues shrinking the PR-A review surface, matching the established B/C/D/E revert pattern. Once these land on 8.0.x and 8.0.x is merged back into this branch, the reverted changes return through the merge, so the final state of stage-hibernate7 is unchanged - only the diff visible on PR-A is reduced. Reverted content: grails.gorm.tests -> grails.gorm.specs package rename (PR #15688, PR-I) Renames the test package back to grails.gorm.tests (the 8.0.x convention) across the three affected test trees: hibernate5 core (90 files), hibernate7 core (90 files), and grails-datamapping-core-test (18 files). The mongo portion was already reverted in the prior B/C/D/E revert. Hibernate 5 Micronaut BOM split (PR #15689, PR-F) Removes grails-hibernate5-micronaut-bom, its sample app (micronaut-hibernate5), and all h5-micronaut references in settings.gradle, dependencies.gradle, publish-root-config.gradle, validateMicronautBom, the doc-generation task, and the Micronaut config/upgrade guides. The generic grails-micronaut-bom is retained. NOT reverted (intentionally kept - the actual PR-A work): - The hibernate5 -> hibernate7 baseline clone - grails-hibernate7-micronaut-bom, its sample app, and all h7 references (settings/dependencies/publish/plugin/doc-gen/guides) Verified: ./gradlew help configures cleanly; compileTestGroovy passes for grails-datamapping-core-test, grails-data-hibernate5-core, and grails-data-hibernate7-core (the three renamed trees); grails-hibernate7 -micronaut-bom still publishes. Assisted-by: claude-code:claude-4.7-opus
|
This change is IMO not needed to move forward. We can create a low-priority task that suggest the change, and do it when we have a 8.0.0 GA |
FYI: in addition to renaming / moving, a lot of tests were broken due to the rename. Several of them have dynamic code that imports these tests. It's actually a lot of work to undo this, but if James F has already done this or is willing I am ok. What I am saying is it's more convenient to merge it - it's more work to undo it. |
If that's the case, then let's save the work of undoing and spent it on more important issues. |
borinquenkid
left a comment
There was a problem hiding this comment.
Recommendation: Merge It. The PR achieves total consistency across both grails-data-hibernate5 and grails-datamapping-core-test. Because it is a pure renaming refactor with no functional modifications to the actual Spock assertions or execution lifecycle, the risk of breaking runtime build stability is incredibly low.
It is much better to pull the band-aid off now, align the package architecture with modern Spock conventions, and let the team build on a unified foundation going forward.
✅ All tests passed ✅🏷️ Commit: 96b88bb Learn more about TestLens at testlens.app. |
|
Closing since we decided to not accept |
Step 1 (PR-I, DRAFT): rename
grails.gorm.tests->grails.gorm.specsWhat this does
Renames the legacy
grails.gorm.testsSpock-spec packages tograils.gorm.specsin:grails-data-hibernate5(90 specs)grails-datamapping-core-test(18 specs)Pure package rename - file moves plus
package/ import updates, no behavioural change.Scope notes
8.0.x).grails.gorm.testspackages (each module's specs are independent / module-local).Assisted-by: claude-code:claude-4.7-opus