Add asset pipeline configuration metadata#445
Merged
jdaugherty merged 4 commits intoMar 4, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds Spring configuration metadata for Grails asset pipeline properties to enable IDE autocomplete and documentation support. The changes include creating a metadata JSON file, generating documentation from it, and integrating the documentation into the existing docs structure.
Changes:
- Added Spring configuration metadata JSON file defining 23 asset pipeline configuration properties
- Created a Gradle task to automatically generate AsciiDoc documentation from the metadata
- Integrated the generated configuration properties reference into the documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| asset-pipeline-grails/src/main/resources/META-INF/spring-configuration-metadata.json | Defines Spring configuration metadata for 23 grails.assets.* properties including types, descriptions, and default values |
| asset-pipeline-docs/src/asciidoc/configurationProperties.adoc | Generated documentation table listing all configuration properties with descriptions and defaults |
| asset-pipeline-docs/build.gradle | Adds generateConfigurationProperties task to convert metadata JSON to AsciiDoc format |
| asset-pipeline-docs/src/asciidoc/index.adoc | Includes the new configuration properties section in the documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The generation logic was treating empty strings the same as null values, showing '-' instead of the actual empty string default for digestSalt. Now distinguishes null (no default) from empty string (explicit default).
The file is regenerated by generateConfigurationProperties task every build. Committing it creates unnecessary diff noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary