Unify how server responses are written into the client cache - #96876
Merged
acdlite merged 1 commit intoAug 13, 2026
Conversation
Contributor
Tests PassedCommit: b44a4b0 |
Contributor
Stats from current PR🔴 3 regressions, 1 improvement
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
Build Cache
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (8 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsfailed to diff📎 Tarball URLCommit: b44a4b0 |
acdlite
force-pushed
the
acdlite/rsc-response-format/06-unify-response-writes
branch
from
August 10, 2026 20:34
220bac8 to
3bf1c27
Compare
acdlite
force-pushed
the
acdlite/rsc-response-format/06-unify-response-writes
branch
from
August 10, 2026 23:08
3bf1c27 to
ac9fee0
Compare
acdlite
marked this pull request as ready for review
August 10, 2026 23:10
acdlite
force-pushed
the
acdlite/rsc-response-format/06-unify-response-writes
branch
from
August 12, 2026 03:11
ac9fee0 to
861a757
Compare
ztanner
approved these changes
Aug 12, 2026
acdlite
force-pushed
the
acdlite/rsc-response-format/06-unify-response-writes
branch
from
August 13, 2026 01:34
861a757 to
bdd8b23
Compare
Every flow that writes a server response into the client cache now goes through a single function, writeServerResponseIntoCache. This is preparation for subsequent steps in this stack that migrate even more callers to this unified path. While we're modifying it, fetchSegmentPrefetchesUsingDynamicRequest is renamed to fetchSegmentPrefetchesUsingRuntimeRequest: these responses are produced by a runtime request, and "dynamic" refers to non-cached data, which prefetch responses never contain. One subtle fix that fell out of the unification: a runtime prefetch response that carries no transport data used to make the flow bail before writing anything; now the shared function rejects the pending entries it was given, the same as a build id mismatch.
acdlite
force-pushed
the
acdlite/rsc-response-format/06-unify-response-writes
branch
from
August 13, 2026 20:35
bdd8b23 to
b44a4b0
Compare
acdlite
deleted the
acdlite/rsc-response-format/06-unify-response-writes
branch
August 13, 2026 22:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every flow that writes a server response into the client cache now goes through a single function, writeServerResponseIntoCache.
This is preparation for subsequent steps in this stack that migrate even more callers to this unified path.
While we're modifying it, fetchSegmentPrefetchesUsingDynamicRequest is renamed to fetchSegmentPrefetchesUsingRuntimeRequest: these responses are produced by a runtime request, and "dynamic" refers to non-cached data, which prefetch responses never contain.
One subtle fix that fell out of the unification: a runtime prefetch response that carries no transport data used to make the flow bail before writing anything; now the shared function rejects the pending entries it was given, the same as a build id mismatch.