[Documentation] Add missing default extension points - #3014
Merged
Conversation
Telroshan
approved these changes
Nov 12, 2024
Telroshan
left a comment
Collaborator
There was a problem hiding this comment.
Good catch! This was indeed an omission, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the page Building htmx Extensions it includes an incomplete list of the extension points available to override. These are
init, which I can see is used by official htmx extensions, andgetSelectorswhich has a test covering its usage.Testing
Coped from source code, which is already covered by tests.
I cross references this with how they're invoked to make sure I wasn't missing any parameters.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded