close
Skip to content

Boost execute function, being able to handle arguments#36652

Merged
GeoSot merged 2 commits into
mainfrom
gs/ref-execute
Oct 7, 2022
Merged

Boost execute function, being able to handle arguments#36652
GeoSot merged 2 commits into
mainfrom
gs/ref-execute

Conversation

@GeoSot

@GeoSot GeoSot commented Jun 30, 2022

Copy link
Copy Markdown
Member

Micro refactoring of execute function to be able to return results and use given arguments

@GeoSot GeoSot changed the title Boost execute function, being able to use arguments Boost execute function, being able to handle arguments Jul 1, 2022
@GeoSot GeoSot force-pushed the gs/ref-execute branch 2 times, most recently from e7d4327 to 0dc9f6b Compare July 19, 2022 14:10
@GeoSot GeoSot force-pushed the gs/ref-execute branch 2 times, most recently from ee8fac5 to 86989e2 Compare September 6, 2022 21:57
@GeoSot GeoSot force-pushed the gs/ref-execute branch 2 times, most recently from 29d427a to 7af8a75 Compare October 3, 2022 22:38
@GeoSot GeoSot requested a review from julien-deramond October 5, 2022 14:09
@GeoSot GeoSot marked this pull request as ready for review October 5, 2022 14:10
@GeoSot GeoSot requested a review from a team as a code owner October 5, 2022 14:10

@julien-deramond julien-deramond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment proposed for a unit test sentence

LGTM! Haven't spotted any regressions, unit test covers the cases 🚀

Comment thread js/tests/unit/util/index.spec.js Outdated
GeoSot and others added 2 commits October 7, 2022 15:21
@GeoSot GeoSot merged commit 4cb046a into main Oct 7, 2022
@GeoSot GeoSot deleted the gs/ref-execute branch October 7, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants