close
Skip to content

only exit zen mode by workbench.action.exitZenMode if its already in zen mode - #144217

Merged
Jackson Kearl (JacksonKearl) merged 1 commit into
microsoft:mainfrom
kkakroo:exitZenMode-fix
Mar 2, 2022
Merged

only exit zen mode by workbench.action.exitZenMode if its already in zen mode#144217
Jackson Kearl (JacksonKearl) merged 1 commit into
microsoft:mainfrom
kkakroo:exitZenMode-fix

Conversation

@kkakroo

Copy link
Copy Markdown
Contributor

This PR fixes #140392

Issue

workbench.action.exitZenMode is toggling Zen mode.

Fix

For workbench.action.exitZenMode added a check to ensure Zen Mode is only toggled when it's actually in Zen Mode.

Test

  • Associate a shortcut to workbench.action.exitZenMode.
  • The shortcut only exits Zen Mode and doesn't toggle it anymore.

@kkakroo Karan Kakroo (kkakroo) changed the title only exit zen mode by workbench.action.exitZenMode if its already in Zen Mode only exit zen mode by workbench.action.exitZenMode if its already in zen mode Mar 1, 2022
@JacksonKearl

Copy link
Copy Markdown
Contributor

Thanks!

@kkakroo
Karan Kakroo (kkakroo) deleted the exitZenMode-fix branch March 2, 2022 02:22
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command "workbench.action.exitZenMode" would turn on ZenMode when not in ZenMode

2 participants