close
Skip to content

Fix various pieces of CI bitrot#428

Merged
glyph merged 14 commits into
twisted:trunkfrom
cjwatson:fix-ci
May 28, 2026
Merged

Fix various pieces of CI bitrot#428
glyph merged 14 commits into
twisted:trunkfrom
cjwatson:fix-ci

Conversation

@cjwatson

@cjwatson cjwatson commented May 28, 2026

Copy link
Copy Markdown
Contributor

Among other things, this drops support for Python 3.8.

Fixes #427

@cjwatson

Copy link
Copy Markdown
Contributor Author

I've done my best here, but I have no idea what's going on with the test failures. Help?

`_converted` can yield field values whose filename is None.
@glyph

glyph commented May 28, 2026

Copy link
Copy Markdown
Member

I've done my best here, but I have no idea what's going on with the test failures. Help?

For starters, try upgrading the werkzeug pin in [dev]?

@glyph

glyph commented May 28, 2026

Copy link
Copy Markdown
Member

Just did so myself and things look a bit better, let me try pushing this.

@glyph

glyph commented May 28, 2026

Copy link
Copy Markdown
Member

Looks like this will need to absorb #426

Use appropriate :class:`twisted.web.resource.IResource` instead of
`IResource`.

Use double backticks to mark allow_redirects=False as a code example.

Use double backticks for basic python types, as used elsewhere in the
same documentation.

Fixes: twisted#423
@cjwatson

Copy link
Copy Markdown
Contributor Author

The Python 3.10 test failures in that last run seem about the same as before. I cherry-picked the fix for #426 though, just to try to clear things up slightly.

@cjwatson

Copy link
Copy Markdown
Contributor Author

Since GHA likes to stop at the first failure, I tried these locally. py39-twisted_lowest, py39-twisted_latest, py39-twisted_trunk, and py310-twisted_lowest fail. Later versions of Python, and Python 3.10 with later versions of Twisted, succeed.

@glyph

glyph commented May 28, 2026

Copy link
Copy Markdown
Member

Since GHA likes to stop at the first failure, I tried these locally. py39-twisted_lowest, py39-twisted_latest, py39-twisted_trunk, and py310-twisted_lowest fail. Later versions of Python, and Python 3.10 with later versions of Twisted, succeed.

I think the issue is probably that older Twisted no longer works with current Cryptography. I am adding some extra debug logging stuff so that at least i can see what's going on in the httpbin server, and seeing builtins.ValueError: Context has already been used to create a Connection, it cannot be mutated again makes me feel like this is confirmed

@glyph

glyph commented May 28, 2026

Copy link
Copy Markdown
Member

@cjwatson I'm inclined to approve and merge if this turns green; if it were lower priority I'd wait for someone who hadn't worked on it, but we should get trunk back to green ASAP.

@glyph glyph merged commit 1665d93 into twisted:trunk May 28, 2026
17 checks passed
@cjwatson

Copy link
Copy Markdown
Contributor Author

Thanks for figuring this out!

@cjwatson cjwatson deleted the fix-ci branch May 28, 2026 23:59
This was referenced May 29, 2026
@glyph

glyph commented May 29, 2026

Copy link
Copy Markdown
Member

Thanks for getting it started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI is broken

2 participants