Pass the same log filename to logging plugins on start/stop requests#33583
Merged
thaJeztah merged 1 commit intoJun 8, 2017
Merged
Conversation
Signed-off-by: Peter Bücker <peter.buecker@gmail.com>
40 tasks
Member
|
Thanks @naag ! Congratulations with your first contribution 🎉 |
Contributor
Author
|
Thanks @cpuguy83 and @thaJeztah! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Bücker peter.buecker@gmail.com
- What I did
Provide a solution for #33569.
- How I did it
The
/LogDriver.StopLoggingrequest needs additional context (basePath) to provide the correct filename to the logging plugin. This context was added since I found no way to retrieve it from existing data structures at hand.- How to verify it
Rerun the steps given at #33569.
- Description for the changelog
Pass the same log filename to logging plugins on start/stop requests.