Use a neutral icon for disabled features and experiments in the AI Status widget#720
Conversation
…AI Status widget Disabled features and experiments were rendered with a red cross (dashicons-no + icon--error), which reads as an error state even though being disabled is an expected, healthy configuration. Render them with a gray neutral marker instead (dashicons-marker + the existing ai-dashboard-status__icon--neutral style), keeping the red error styling reserved for actual problems. Also expose the state to screen readers via screen-reader-text and hide the decorative icons with aria-hidden, since the state was previously conveyed by color and glyph alone. The Connectors column and the getting-started checklist are unchanged: an unconfigured connector and incomplete setup steps still warrant attention. Fixes WordPress#718
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @i-anubhav-anand. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
left a comment
There was a problem hiding this comment.
While this doesn't exactly follow the suggestion in the issue (switches to the marker icon instead of always using the yes-alt icon), I do think this looks better than what we have. I'd maybe lean towards something like the minus icon but that's minor enough I don't think worth changing:
| Marker icon | Minus icon |
|---|---|
 |
 |
|
@i-anubhav-anand One request going forward, can you ensure your PR descriptions follow our PR template? We have certain sections in there that we want on each PR (like changelog entry and the level of AI assistance used) |
|
Thanks for merging, @dkotter — Noted on the template; I'll include the changelog entry and AI disclosure on future PRs. |
|
@i-anubhav-anand if you're able to confirm your WordPress.org username (and ideally link it with your GitHub account), then I can ensure its properly credited in the AI plugin release (and associated AI Contributor badge)... thanks! |
Motivation for the change, related issues
Fixes #718.
The AI Status dashboard widget renders disabled features and experiments with a red cross (
dashicons-no+ the error icon style). A red cross reads as an error, failure, or missing configuration — but a disabled experiment is an expected, healthy state the user chose. A dashboard full of red crosses right after login suggests something is wrong when nothing is.Implementation details
includes/Admin/Dashboard/AI_Status_Widget.php— in the Features and Experiments columns of the status view:dashicons-markerwith the existingai-dashboard-status__icon--neutralstyle (gray, already defined insrc/admin/dashboard/index.scssbut previously unused) instead ofdashicons-no+ai-dashboard-status__icon--error.dashicons-yes-alt.screen-reader-text"Enabled:"/"Disabled:" labels andaria-hidden="true"on the decorative icons — the state was previously conveyed by color/glyph alone.Deliberately unchanged, since both still warrant attention:
dashicons-dismiss).This matches the proposal mockup in #718: green check = enabled, neutral gray = disabled, red reserved for actual problems.
Testing Instructions (or ideally a Blueprint)
npm run test:php -- --filter AI_Status_WidgetTest— includes 4 new tests covering the status view: column rendering, success icon for enabled experiments, neutral (never error) icon for disabled experiments, and the screen-reader state labels.