Add voluntary exit tests for builders#4908
Merged
jtraglia merged 8 commits intoFeb 12, 2026
Merged
Conversation
jtraglia
reviewed
Feb 9, 2026
jtraglia
approved these changes
Feb 9, 2026
Member
There was a problem hiding this comment.
@AbolareRoheemah thank you very much for the tests!
I made some little changes & moved things around, but they are still your tests 🙂
While reviewing this, I noticed a mistake with the deposit epoch finalization check. See the comment above.
Contributor
Author
You’re most welcome. Thanks for your review 🫡
Seen. Thanks! 🙏
Seen and noted 🤝 |
is_active_builder and add voluntary exit tests
is_active_builder and add voluntary exit tests
lodekeeper
added a commit
to lodekeeper/lodestar
that referenced
this pull request
Mar 14, 2026
The builder_voluntary_exit__success test case in v1.7.0-alpha.3 is missing the voluntary_exit.ssz_snappy input file. This is a bug in the spec test generator — the test function doesn't yield the voluntary_exit input. All other builder voluntary exit tests (invalid cases) correctly include the input file. See: ethereum/consensus-specs#4908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive test coverage for builder voluntary exits in Gloas.
Fixes #4904