Add tests for on_payload_attestation_message#5206
Merged
jtraglia merged 6 commits intoMay 12, 2026
Merged
Conversation
jtraglia
reviewed
May 5, 2026
jtraglia
reviewed
May 5, 2026
jtraglia
reviewed
May 5, 2026
ericsson49
reviewed
May 6, 2026
Member
|
@brech1 I will approve/merge this after we resolve feedback! |
192095a to
ef2efaa
Compare
ef2efaa to
44c14b4
Compare
Member
Author
|
Apologies for the rebase, needed a clean diff for some whitespace changes. Regarding duplicated PTC members votes, here's a related ongoing thread discussing this: It's certainly an option to drop this scenario and focus on changing this behavior instead |
44c14b4 to
0f33ce8
Compare
Member
Author
|
Applied the updates for the #5222 spec changes. I removed the following tests:
I inlined the Updated test functions name for correct full spec function name. |
jtraglia
reviewed
May 11, 2026
jtraglia
reviewed
May 11, 2026
jtraglia
reviewed
May 11, 2026
jtraglia
reviewed
May 11, 2026
jtraglia
approved these changes
May 11, 2026
jtraglia
left a comment
Member
There was a problem hiding this comment.
Awesome. These look great. Just a few little nit fixes & we can get this merged.
b73ae2b to
8985840
Compare
jtraglia
approved these changes
May 12, 2026
This was referenced May 13, 2026
1 task
nflaig
pushed a commit
to ChainSafe/lodestar
that referenced
this pull request
Jun 5, 2026
) **Motivation** The consensus-specs repo added new fork choice test vectors for on_payload_attestation_message (ethereum/consensus-specs#5206). Lodestar's spec test runner needs a handler for this step type so the nightly spec tests can run these vectors instead of failing on an unrecognized step. **Description** Adds test infrastructure to handle `on_payload_attestation_message` steps in fork choice spec tests: - OnPayloadAttestationMessage step type and `isPayloadAttestationMessage` type guard - SSZ fixture loader for `payload_attestation_message_*.ssz_snappy` files - Step handler that deserializes the message and calls `notifyPtcMessages` Closes #9364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR main objective is to add tests for the
on_payload_attestation_messagespec function.Changes
on_payload_attestationis_from_blockoptional field.payload_timeliness_voteandpayload_data_availability_votechecks (up to date with Distinguish absent PTC votes from negative votes #5180).PayloadAttestationMessagefixture prefix topayload_attestation_message_<root>to match the SSZ type.