Fix invalid block-root membership check in fork-choice helper#5259
Merged
brech1 merged 3 commits intoMay 27, 2026
Merged
Conversation
jtraglia
approved these changes
May 18, 2026
jtraglia
left a comment
Member
There was a problem hiding this comment.
Thanks! This appears to be a valid fix. @ericsson49 can you confirm?
Contributor
yes, nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a correctness gap in fork-choice compliance test validation by ensuring invalid block events are checked against the fork-choice store’s block-root index. This is necessary because the previous check compared a block root to stored block objects, which could silently pass even when the invalid-block path was not being validated as intended; as a result, store-pollution regressions in invalid scenarios could be missed and test-vector reliability reduced.
Checklist
make lintto check formattingmake testto check testsRelations
Related to #3831