close
Skip to content

Add avif image file support#32508

Merged
lunny merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-avif
Nov 15, 2024
Merged

Add avif image file support#32508
lunny merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-avif

Conversation

@wxiaoguang

@wxiaoguang wxiaoguang commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Most modern browsers support it now

Update ALLOWED_TYPES #96 https://gitea.com/gitea/docs/pulls/96

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2024
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Nov 14, 2024
@github-actions github-actions Bot added modifies/go docs-update-needed The document needs to be updated synchronously labels Nov 14, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Nov 14, 2024
@silverwind

Copy link
Copy Markdown
Member

Current GitHub allowed files list below, can you merge it?

.gif,.jpeg,.jpg,.mov,.mp4,.png,.svg,.webm,.cpuprofile,.csv,.dmp,.docx,.fodg,.fodp,.fods,.fodt,.gz,.json,.jsonc,.log,.md,.odf,.odg,.odp,.ods,.odt,.patch,.pdf,.pptx,.tgz,.txt,.xls,.xlsx,.zip

@wxiaoguang

Copy link
Copy Markdown
Contributor Author

Current GitHub allowed files list below, can you merge it?

.gif,.jpeg,.jpg,.mov,.mp4,.png,.svg,.webm,.cpuprofile,.csv,.dmp,.docx,.fodg,.fodp,.fods,.fodt,.gz,.json,.jsonc,.log,.md,.odf,.odg,.odp,.ods,.odt,.patch,.pdf,.pptx,.tgz,.txt,.xls,.xlsx,.zip

If you could point out what's the difference.

Comment thread custom/conf/app.example.ini Outdated
Comment thread modules/setting/attachment.go
Co-authored-by: silverwind <me@silverwind.io>
@silverwind

Copy link
Copy Markdown
Member

I merged the lists, .dmp and .jsonc are added:

.avif,.cpuprofile,.csv,.dmp,.docx,.fodg,.fodp,.fods,.fodt,.gif,.gz,.jpeg,.jpg,.json,.jsonc,.log,.md,.mov,.mp4,.odf,.odg,.odp,.ods,.odt,.patch,.pdf,.png,.pptx,.svg,.tgz,.txt,.webm,.webp,.xls,.xlsx,.zip

Comment thread modules/typesniffer/typesniffer.go
@wxiaoguang

Copy link
Copy Markdown
Contributor Author

The list in code is up-to-dated. Some items are missing in the app.example.ini due to #29688 .......

@silverwind

Copy link
Copy Markdown
Member

The list in code is up-to-dated. Some items are missing in the app.example.ini due to #29688 .......

Not sure how the mismatch came to be. What there an error in #29688?

@wxiaoguang

Copy link
Copy Markdown
Contributor Author

The list in code is up-to-dated. Some items are missing in the app.example.ini due to #29688 .......

Not sure how the mismatch came to be. What there an error in #29688?

app.example.ini wasn't updated there

@silverwind

Copy link
Copy Markdown
Member

Ah, I see. Yes, that was an error.

Comment thread modules/typesniffer/typesniffer.go
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 14, 2024
@silverwind

Copy link
Copy Markdown
Member

Optional, but might be good to verify whether avif files can be used as avatar. I assume it will need some changes.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 14, 2024
@lunny lunny enabled auto-merge (squash) November 14, 2024 22:54
@lunny lunny merged commit 6f1de0a into go-gitea:main Nov 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 15, 2024
@wxiaoguang wxiaoguang deleted the fix-avif branch November 15, 2024 01:01
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 15, 2024
* giteaofficial/main:
  Fix oauth2 error handle not return immediately (go-gitea#32514)
  Fix incorrect project page CSS class (go-gitea#32510)
  Add avif image file support (go-gitea#32508)
  Reduce integration test overhead (go-gitea#32475)
  Remove jQuery import from some files (go-gitea#32512)
  Trim title before insert/update to database to match the size requirements of database (go-gitea#32498)
  Reimplement GetUserOrgsList to make it simple and clear (go-gitea#32486)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs-update-needed The document needs to be updated synchronously lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants