Fix image carousel showing UUID on hover in modal editor title#320739
Merged
dmitrivMS merged 4 commits intoJun 10, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a (long) title string to the editor label model so consumers can display a richer title (e.g., tooltip/ARIA) for the active editor.
Changes:
- Populate a new
titlefield usingactiveEditor.getTitle(Verbosity.LONG)in the label data for the active editor.
dmitrivMS
approved these changes
Jun 10, 2026
Contributor
|
@arun-357 Thank you! |
justschen
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301984
Problem
Hovering the image carousel title in the modal header shows a raw UUID, and the UUID changes every time the carousel is reopened.
Root cause:
generateUuid()(imageCarousel.contribution.ts), whichImageCarouselEditorInputturns into its resource URI:vscode-imagecarousel:///<uuid>.updateLabel()inmodalEditorPart.ts) callsResourceLabel.setResource()without atitleoption.ResourceLabelWidget.render()(labels.ts) falls back tolabelService.getUriLabel(resource)for the tooltip — i.e. the UUID URI.Fix
Pass
title: activeEditor.getTitle(Verbosity.LONG)in theResourceLabeloptions for the modal header, mirroring how editor tabs set their hover (multiEditorTabsControl.ts,editorTabsControl.ts#getHoverTitle).This makes the modal header hover behave like existing non-file editor tabs — e.g. the Settings editor tab, whose hover shows "Settings" (its
getTitle(Verbosity.LONG)falls back togetName()). The carousel hover now shows its stable title ("Image Carousel" / "Images Preview") instead of a per-open UUID.The fix applies to all modal editor inputs (chat management, agent plugin, workspace trust, etc.), not just the image carousel. File editors opened modally (
workbench.editor.useModal: "all") keep their useful full-path hover, sinceFileEditorInput.getTitle(Verbosity.LONG)returns the full path — no behavior change there.Before / After
Before:

After:

Verification
"workbench.editor.useModal": "all": a file opened in the modal still shows its full path on hover.compile-check-ts-nativeand ESLint pass.