return frequency in signal.signal_filter._signal_filter_sanitize as scalar#998
Merged
DominiqueMakowski merged 1 commit intoJun 14, 2024
Conversation
|
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
In order to avoid the DeprecationWarning thrown by NumPy (
DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)) , thefreqvariable should be returned as a scalar and not as a listProposed Changes
Change the
freqsvariable from list to a scalar when filter is eitherlowpassorhighpassChecklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)